should be able to create a redis ring from universal options and universal ctor #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersal ctor Signed-off-by: Tiago Peczenyj <tpeczenyj@weborama.com>
Co-authored-by: Hu Ying <ying.hu@shopee.com>
Signed-off-by: kindknow <iturf@sina.com> Co-authored-by: Monkey <golang@88.com>
Signed-off-by: deferdeter <deferdeter@outlook.com>
Co-authored-by: Monkey <golang@88.com>
* Handle IPv6 in isMovedError * Simplify GetAddr --------- Co-authored-by: Monkey <golang@88.com>
* Remove skipping span creation by checking parent spans * Update CHANGELOG
Signed-off-by: monkey92t <golang@88.com>
…ersal ctor Signed-off-by: Tiago Peczenyj <tpeczenyj@weborama.com>
…reate-a-ring-from-universal-options' into should-be-able-to-create-a-ring-from-universal-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we can't create a ring in universal ctor / universal options
There is a clash of
Addrsfield name, that is a slice of strings for all flavors of redis universal client and the ring, that uses amap[string]stringnot anymore, using
AddressMapfield we can create a Ring will full colors :)