Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix SETINFO ensuring it is set-and-forget #2915

Merged
merged 10 commits into from
Feb 20, 2024

Conversation

ofekshenawa
Copy link
Collaborator

@ofekshenawa ofekshenawa commented Feb 19, 2024

Updating SETINFO so that when it is sent, it is set-and-forget. This enabled SETINFO to run only where appropriate (i.e redis 7.2+). Once ready, this release should:

closes #2910
closes #2911
closes #2914

@ofekshenawa ofekshenawa reopened this Feb 19, 2024
@git-hulk
Copy link
Contributor

git-hulk commented Feb 19, 2024

@ofekshenawa How about disabling identity by default as mentioned in #2880 (comment)? guess most of the users are running Redis < 7.2 and enabling this may affect the performance of the connect stage.

redis.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
dvora-h
dvora-h previously approved these changes Feb 20, 2024
@chayim chayim changed the title Exexcute client set-info outside the pipeline Execute client set-info outside the pipeline Feb 20, 2024
@chayim chayim added the bug label Feb 20, 2024
@chayim chayim changed the title Execute client set-info outside the pipeline bug: Fix SETINFO ensuring it is set-and-forget Feb 20, 2024
@ofekshenawa ofekshenawa merged commit 5da49b1 into master Feb 20, 2024
9 checks passed
@ofekshenawa ofekshenawa deleted the os-remove-validation-check-on-setinfo branch June 19, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants