Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

0.4.0 fails with iojs v3.0.0 #95

Closed
taoeffect opened this issue Aug 5, 2015 · 11 comments
Closed

0.4.0 fails with iojs v3.0.0 #95

taoeffect opened this issue Aug 5, 2015 · 11 comments

Comments

@taoeffect
Copy link

I'm not sure whether this is related to #94, but I know this:

See the full error/build log here:

https://travis-ci.org/okTurtles/dnschain/jobs/74161603

@badboy
Copy link
Contributor

badboy commented Aug 5, 2015

Gnaaah, they keep breaking nan with new io.js releases. Upgrading nan should do the trick.

@badboy
Copy link
Contributor

badboy commented Aug 5, 2015

Except that nan 2 breaks lots of other stuff. I put this on my todo, hopefully until the end of the week.

@badboy
Copy link
Contributor

badboy commented Aug 7, 2015

Guess this have to wait for a bit. There is no documentation on the upgrade process for NAN v2 (yet).

@taoeffect
Copy link
Author

Are we sure this issue is fixed?

Travis still erroring with it: https://travis-ci.org/okTurtles/dnschain/jobs/77775121

@badboy
Copy link
Contributor

badboy commented Aug 29, 2015

Atleast our own build didn't fail: https://travis-ci.org/redis/hiredis-node/jobs/76797442

I'll look into this tomorrow.

@badboy
Copy link
Contributor

badboy commented Aug 30, 2015

@taoeffect I can't reproduce it locally. It builds just fine for me with the latest io.js. Even a npm install in your dnschain project works (after changing it to latest hiredis-node, not sure where your commit for this ended up)

@taoeffect
Copy link
Author

@badboy This appears to be due to a difference between our .travis.yml files. Yours explicitly installs g++-4.8, whereas ours uses the default settings.

So, since most people don't customize their .travis.yml file in this way, is it possible to make it work with the defaults? If not, perhaps you can update your README to instruct people that hiredis requires making customizations to .travis.yml?

@badboy
Copy link
Contributor

badboy commented Aug 31, 2015

Thanks for checking, I see what I can do about it.

@badboy
Copy link
Contributor

badboy commented Aug 31, 2015

Latest node/io.js has gcc/g++ 4.8 as a prerequisite.
gcc 4.6, which is the default on travis, is more than 3 years old, so moving on seems reasonable.

I will add it to the readme.

@taoeffect
Copy link
Author

Awesome, thanks @badboy!

@NicolasRitouet
Copy link

I had the same issue on CircleCI with hiredis 0.4.1 on node 4.2.0.
Adding this to circle.yml fixed the problem:

machine:
  pre:
    - sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.6 10
    - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.6 10
    - sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.9 20
    - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.9 20

Thanks @badboy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants