-
Notifications
You must be signed in to change notification settings - Fork 84
0.4.0 fails with iojs v3.0.0 #95
Comments
Gnaaah, they keep breaking nan with new io.js releases. Upgrading nan should do the trick. |
Except that nan 2 breaks lots of other stuff. I put this on my todo, hopefully until the end of the week. |
Guess this have to wait for a bit. There is no documentation on the upgrade process for NAN v2 (yet). |
Are we sure this issue is fixed? Travis still erroring with it: https://travis-ci.org/okTurtles/dnschain/jobs/77775121 |
Atleast our own build didn't fail: https://travis-ci.org/redis/hiredis-node/jobs/76797442 I'll look into this tomorrow. |
@taoeffect I can't reproduce it locally. It builds just fine for me with the latest io.js. Even a |
@badboy This appears to be due to a difference between our So, since most people don't customize their |
Thanks for checking, I see what I can do about it. |
Latest node/io.js has gcc/g++ 4.8 as a prerequisite. I will add it to the readme. |
Awesome, thanks @badboy! |
I had the same issue on CircleCI with hiredis 0.4.1 on node 4.2.0.
Thanks @badboy |
I'm not sure whether this is related to #94, but I know this:
See the full error/build log here:
https://travis-ci.org/okTurtles/dnschain/jobs/74161603
The text was updated successfully, but these errors were encountered: