Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Update for NAN 2.0 #96

Merged
merged 1 commit into from
Aug 21, 2015
Merged

Update for NAN 2.0 #96

merged 1 commit into from
Aug 21, 2015

Conversation

kkoopa
Copy link
Contributor

@kkoopa kkoopa commented Aug 14, 2015

Fixes #95.

@badboy
Copy link
Contributor

badboy commented Aug 14, 2015

someone took care of it \o/ Thanks, I will check that out next week.

@bcoe
Copy link

bcoe commented Aug 17, 2015

@badboy, @kkoopa excited to get this merged so that we can run it against the node-redis test-suite 👍 awesome work getting this patched so fast.

@badboy
Copy link
Contributor

badboy commented Aug 18, 2015

I read it and all looks good so far. I'm just waiting for appveyor to not be broken anymore and then I will merge and release it.

badboy added a commit that referenced this pull request Aug 21, 2015
@badboy badboy merged commit 3136f76 into redis:master Aug 21, 2015
@kkoopa kkoopa deleted the nan2 branch August 21, 2015 12:56
@bcoe
Copy link

bcoe commented Aug 21, 2015

@badboy mind pushing a release to npm when you have a moment?

@badboy
Copy link
Contributor

badboy commented Aug 22, 2015

Done, thanks @kkoopa.

I will automate the process in the future, so releases will happen more easily and faster.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants