Unsubscribe handling in async #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis responds to an unsubscribe with one or many replies, depending on the current subscribe state. When channels/patterns names are provided in a command each given name will trigger a reply even if duplicated or not subscribed to. To know when we can return from the subscribed state we need to do bookkeeping on pending additional unsubscribe replies, and make sure we receive them all before switching state.
|
The alternative solution would be to only send unsubscribe to channels/patterns that is subscribed to, i.e. change the command content, which is a bit more intrusive. We still need to bookkeep which channels/patterns that we have sent an unsubscribe to. |
|
Nice improvement, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis responds to an unsubscribe with one or many replies, depending on the current subscribe state.
When channel/pattern names are provided in the unsubscribe command each given name will trigger a reply
even if duplicated or not subscribed to.
To know when we can switch the internal subscribe state we need to make sure all pending replies have been
processed before doing the switch. This is done by bookkeeping pending additional unsubscribe replies.
Fixes #1039