New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nan in RESP3 double #1133

Merged

michael-grunder merged 1 commit into redis:master from filipecosta90:resp3.nan

Nov 14, 2022

Contributor

filipecosta90 commented Nov 6, 2022 •

edited

Given redis/redis-specifications#10, addresses redis/redis-specifications#9 in hiredis.


          Add support for nan in RESP3 double

293b2ce

filipecosta90 mentioned this pull request

Add support for nan in RESP3 double redis/redis-specifications#9

Closed

Collaborator

michael-grunder commented Nov 6, 2022

Thanks for the submission.

I'm tagging v1.1.0-rc1 this evening and think this may need to go into a subsequent release.

Once merged, applications that use hiredis will need to account for nan whereas presently, that would be treated as an error by hiredis itself.

michael-grunder added the bug label

michael-grunder merged commit f0bdf84 into redis:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment