feat(offlineQueue): add option to limit the offline queue size #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the size of offline queue reaches the , the overflow commands will be flushed with an error. Closes #76
Closed
|
Looks ok to me. Simple option and easy to understand. |
|
I still recommend using bytes to determine if the queue is full or not. The memory is not exact but it's not difficult to have a approximation that is about right. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 7 days if no further activity occurs, but feel free to re-open a closed issue if needed. |
|
This PR, along with #658, seem very important to me in order to prevent an unresponsive Redis server from bringing down an application. Is there a reason for them not having been merged? |
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the size of offline queue reaches the
maxOfflineQueueSize, the overflow commands will beflushed with an error.
Closes #76