SHUTDOWN with optional modifier #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
requested review from
gkorland,
mina-asham and
dengliming
and removed request for
mina-asham
|
@sazzad16 can you add test? |
|
@gkorland To test this properly, we'll need 3 more Redis instances and 3 more test classes. Do you really want all of these? |
dengliming
previously approved these changes
May 14, 2021
gkorland
approved these changes
May 18, 2021
sazzad16
added
backport required
and removed
ready to merge
wait for more reviews
labels
sazzad16
added a commit
that referenced
this pull request
May 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.