Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support jedis migrate keys encoded by gdk #2689

Merged
merged 4 commits into from
Dec 4, 2021
Merged

support jedis migrate keys encoded by gdk #2689

merged 4 commits into from
Dec 4, 2021

Conversation

zeekling
Copy link
Contributor

Expected behavior

use migrate function migrate value success when the key contains china string encoded by gbk.

Actual behavior

use migrate function migrate value failed when the key contains china strings encoded by gbk.

Steps to reproduce:

  1. write china strings encoded by gdb use hiredis.
  2. use clusterGetKeysInSlot get all keys in slot.
  3. migrate keys to other node. its failed due to jedis decode strings by utf-8.

Redis / Jedis Configuration

Jedis version:2.8.2

Redis version:5.0.4

Java version:1.8

issus: #2688

@zeekling zeekling changed the title support jedis migrate keys encoded by gdk failed support jedis migrate keys encoded by gdk Nov 13, 2021
@zeekling zeekling mentioned this pull request Nov 13, 2021
Closed
sazzad16
sazzad16 requested changes Nov 13, 2021
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the method to clusterGetKeysInSlotBinary.

@sazzad16 sazzad16 added this to the 3.8.0 milestone Nov 13, 2021
@sazzad16 sazzad16 linked an issue Nov 13, 2021 that may be closed by this pull request
jedis migrate keys failed encoded by gdk #2688
Closed
@zeekling
Copy link
Contributor Author

Rename the method to clusterGetKeysInSlotBinary.

done!

sazzad16
sazzad16 previously approved these changes Nov 14, 2021
View reviewed changes
@zeekling
Copy link
Contributor Author

pls merge @sazzad16

@sazzad16 sazzad16 merged commit 71cd5f1 into redis:master Dec 4, 2021
sazzad16 added a commit that referenced this pull request Dec 4, 2021
@zeekling @sazzad16
support jedis migrate keys encoded by gdk (#2689)
7261cf5 
* support jedis migrate keys encoded by gdk failed

* Rename method clusterGetBytesKeysInSlot to clusterGetKeysInSlotBinary.

* clusterGetKeysInSlotBinary test name

* fix test exec failed

Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
@zeekling zeekling deleted the migrate_china_keys branch December 16, 2021 14:43
@chayim chayim mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

jedis migrate keys failed encoded by gdk
2 participants
@zeekling @sazzad16