Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XINFO STREAM FULL #2746

Merged
merged 10 commits into from Dec 31, 2021
Merged

Support XINFO STREAM FULL #2746

merged 10 commits into from Dec 31, 2021

Conversation

zeekling
Copy link
Contributor

support XINFO STREAM key FULL [COUNT count] like:

xinfo stream xadd-stream1 full count 10

yangbodong22011
yangbodong22011 reviewed Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@yangbodong22011 yangbodong22011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current code is good for me, but the corresponding commands need to be added to the following classes:

  • Pipeline.java
  • TransactionBase.java
  • MultiNodePipelineBase.java

@sazzad16 sazzad16 added this to the 4.1.0 milestone Dec 16, 2021
@zeekling
Copy link
Contributor Author

zeekling commented Dec 16, 2021 •
edited

done! @yangbodong22011

@yangbodong22011
Copy link
Collaborator

Seems the test ci/circleci: build-linux-8-jdk Expected — Waiting for status to be reported does not pass
@sazzad16 Do you know or can check the reason?
image

@sazzad16
Copy link
Collaborator

@chayim PTAL ^^^

sazzad16
sazzad16 requested changes Dec 19, 2021
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...FullInfo classes should be put into resps package.

src/test/java/redis/clients/jedis/commands/jedis/StreamsCommandsTest.java Show resolved Hide resolved
src/main/java/redis/clients/jedis/BuilderFactory.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/BuilderFactory.java Outdated Show resolved Hide resolved
sazzad16
sazzad16 requested changes Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeekling Please address the change requests.

src/main/java/redis/clients/jedis/params/ConsumerFullInfo.java Outdated Show resolved Hide resolved
sazzad16
sazzad16 requested changes Dec 28, 2021
View reviewed changes
src/main/java/redis/clients/jedis/Jedis.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/Jedis.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/UnifiedJedis.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/UnifiedJedis.java Outdated Show resolved Hide resolved
sazzad16
sazzad16 requested changes Dec 29, 2021
View reviewed changes
src/test/java/redis/clients/jedis/commands/jedis/StreamsCommandsTest.java Show resolved Hide resolved
src/main/java/redis/clients/jedis/resps/StreamGroupFullInfo.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/resps/StreamFullInfo.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/resps/ConsumerFullInfo.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/commands/StreamPipelineBinaryCommands.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/UnifiedJedis.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/TransactionBase.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/Pipeline.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/MultiNodePipelineBase.java Outdated Show resolved Hide resolved
src/main/java/redis/clients/jedis/Jedis.java Outdated Show resolved Hide resolved
@sazzad16 sazzad16 changed the title support XINFO STREAM FULL Support XINFO STREAM FULL Dec 31, 2021
@sazzad16 sazzad16 merged commit c698ba7 into redis:master Dec 31, 2021
@zeekling zeekling deleted the xinfo_stream_full_new branch January 2, 2022 10:13
@sazzad16 sazzad16 mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sazzad16 sazzad16 sazzad16 approved these changes

@yangbodong22011 yangbodong22011 Awaiting requested review from yangbodong22011

@dengliming dengliming Awaiting requested review from dengliming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zeekling @yangbodong22011 @sazzad16 @dengliming