Support GEOSEARCH and GEOSEARCHSTORE commands #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2771 +/- ##
============================================
- Coverage 58.53% 58.39% -0.15%
- Complexity 2935 2996 +61
============================================
Files 170 171 +1
Lines 10426 10681 +255
Branches 605 616 +11
============================================
+ Hits 6103 6237 +134
- Misses 4112 4233 +121
Partials 211 211
Continue to review full report at Codecov.
|
sazzad16
requested changes
Dec 27, 2021
Pipeline also? |
…re' into geosearch_and_geosearchStore # Conflicts: # src/main/java/redis/clients/jedis/CommandObjects.java # src/main/java/redis/clients/jedis/params/GeoSearchParam.java
Yes 😃 |
sazzad16
requested changes
Dec 27, 2021
dengliming
reviewed
Dec 27, 2021
sazzad16
requested changes
Dec 28, 2021
zeekling
reviewed
Dec 28, 2021
zeekling
reviewed
Dec 28, 2021
src/test/java/redis/clients/jedis/commands/jedis/GeoCommandsTest.java
Outdated
Show resolved
Hide resolved
zeekling
reviewed
Dec 28, 2021
src/test/java/redis/clients/jedis/commands/unified/GeoCommandsTestBase.java
Outdated
Show resolved
Hide resolved
sazzad16
previously approved these changes
Dec 28, 2021
sazzad16
requested changes
Dec 28, 2021
There was a problem hiding this comment.
@AvitalFineRedis Undo any change related to GeoRadiusParam.
sazzad16
requested changes
Dec 29, 2021
sazzad16
requested changes
Dec 30, 2021
Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
sazzad16
approved these changes
Dec 30, 2021
dengliming
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support GEOSEARCH and GEOSEARCHSTORE commands.
Also created GeoSearchParam class to support all the params for both commands.
Based on old and un-updated PR
Resolves #2390
Closes #2677