Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support REPLICAOF Command #2811

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Support REPLICAOF Command #2811

merged 5 commits into from
Jan 12, 2022

Conversation

AvitalFineRedis
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #2811 (fc6c565) into master (7c5cead) will decrease coverage by 0.14%.
The diff coverage is 6.66%.

❗ Current head fc6c565 differs from pull request most recent head 0642e5a. Consider uploading reports for the commit 0642e5a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2811      +/-   ##
============================================
- Coverage     58.40%   58.26%   -0.15%     
- Complexity     3009     3011       +2     
============================================
  Files           174      175       +1     
  Lines         10821    10849      +28     
  Branches        621      623       +2     
============================================
+ Hits           6320     6321       +1     
- Misses         4286     4314      +28     
+ Partials        215      214       -1     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Jedis.java 84.56% <0.00%> (-0.52%) ⬇️
...ava/redis/clients/jedis/params/ShutdownParams.java 0.00% <0.00%> (ø)
src/main/java/redis/clients/jedis/Protocol.java 87.09% <100.00%> (ø)
...ava/redis/clients/jedis/JedisClusterInfoCache.java 79.45% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e57fb...0642e5a. Read the comment docs.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deprecate SLAVEOF commands.
You can check #2673 for idea.

Also, put the new methods just after those.

@sazzad16 sazzad16 added this to the 4.1.0 milestone Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants