Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackOverflowError in Transaction #2827

Merged
merged 4 commits into from Jan 19, 2022

Conversation

sazzad16
Copy link
Collaborator

Fixes #2815

@sazzad16 sazzad16 force-pushed the tx-discard-stackoverflow branch 2 times, most recently from 3995b93 to 5e1dfc3 Compare January 18, 2022 12:07
@codecov-commenter
Copy link

Codecov Report

Merging #2827 (3b82dfa) into master (26a682e) will increase coverage by 0.02%.
The diff coverage is 94.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2827      +/-   ##
============================================
+ Coverage     58.42%   58.45%   +0.02%     
  Complexity     3050     3050              
============================================
  Files           177      177              
  Lines         10952    10963      +11     
  Branches        628      629       +1     
============================================
+ Hits           6399     6408       +9     
- Misses         4335     4336       +1     
- Partials        218      219       +1     
Impacted Files Coverage Δ
...main/java/redis/clients/jedis/TransactionBase.java 13.78% <94.28%> (+1.19%) ⬆️
src/main/java/redis/clients/jedis/JedisPubSub.java 69.15% <0.00%> (-1.87%) ⬇️
src/main/java/redis/clients/jedis/Jedis.java 84.71% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a682e...3b82dfa. Read the comment docs.

@sazzad16 sazzad16 added this to the 4.1.0 milestone Jan 18, 2022
@sazzad16 sazzad16 merged commit 0f4bed9 into redis:master Jan 19, 2022
@sazzad16 sazzad16 deleted the tx-discard-stackoverflow branch January 19, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackOverflowError when invoke discard method in Transaction in jedis 4.0.1
4 participants