Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RESET command #3015

Merged
merged 4 commits into from Nov 2, 2023
Merged

Support RESET command #3015

merged 4 commits into from Nov 2, 2023

Conversation

ihaohong
Copy link
Contributor

@ihaohong ihaohong commented Jun 4, 2022

No description provided.

@ihaohong ihaohong mentioned this pull request Jun 4, 2022
Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error:  Tests run: 51, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.279 s <<< FAILURE! - in redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest
Error:  reset(redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest)  Time elapsed: 0.001 s  <<< ERROR!
redis.clients.jedis.exceptions.JedisDataException: NOAUTH Authentication required.
	at redis.clients.jedis.commands.jedis.AllKindOfValuesCommandsTest.reset(AllKindOfValuesCommandsTest.java:1142)

@ihaohong
Copy link
Contributor Author

ihaohong commented Jun 14, 2022

Hi, I fixed the unit test failure, and run it in my workflow: https://github.com/ihaohong/jedis/runs/6883129332?check_suite_focus=true, please review this pull request again, thanks.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2f6712) 71.52% compared to head (8205ccc) 71.46%.

❗ Current head 8205ccc differs from pull request most recent head 5469680. Consider uploading reports for the commit 5469680 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3015      +/-   ##
============================================
- Coverage     71.52%   71.46%   -0.06%     
+ Complexity     4851     4848       -3     
============================================
  Files           288      288              
  Lines         15461    15464       +3     
  Branches       1095     1095              
============================================
- Hits          11058    11051       -7     
- Misses         3927     3934       +7     
- Partials        476      479       +3     
Files Coverage Δ
.../main/java/redis/clients/jedis/CommandObjects.java 85.66% <100.00%> (+0.01%) ⬆️
src/main/java/redis/clients/jedis/Jedis.java 85.21% <100.00%> (-0.04%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 89.50% <100.00%> (-1.11%) ⬇️
...a/redis/clients/jedis/commands/ServerCommands.java 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ihaohong
Copy link
Contributor Author

Hi, what else need me to do for this pull request?

@sazzad16
Copy link
Collaborator

@ihaohong Nothing ATM. Thank you for your patience.

@sazzad16 sazzad16 changed the title Support RESET command (#2952) Support RESET command Nov 1, 2023
@sazzad16 sazzad16 linked an issue Nov 2, 2023 that may be closed by this pull request
@sazzad16 sazzad16 merged commit 65ed601 into redis:master Nov 2, 2023
4 checks passed
@sazzad16
Copy link
Collaborator

sazzad16 commented Nov 2, 2023

@ihaohong Apologies for late and thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support RESET command
5 participants