Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode map in encoded object #3555

Merged
merged 3 commits into from Sep 23, 2023
Merged

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Sep 23, 2023

Clarification: Encode RESP3 map in encoded object

@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance labels Sep 23, 2023
@sazzad16 sazzad16 added this to the 5.0.1 milestone Sep 23, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and no project coverage change.

Comparison is base (eb6893a) 71.46% compared to head (4ff45c6) 71.47%.

❗ Current head 4ff45c6 differs from pull request most recent head 23e6569. Consider uploading reports for the commit 23e6569 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3555   +/-   ##
=========================================
  Coverage     71.46%   71.47%           
  Complexity     4841     4841           
=========================================
  Files           287      287           
  Lines         15432    15432           
  Branches       1093     1093           
=========================================
+ Hits          11029    11030    +1     
  Misses         3927     3927           
+ Partials        476      475    -1     
Files Changed Coverage Δ
.../main/java/redis/clients/jedis/CommandObjects.java 85.77% <83.33%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit e0e2319 into redis:master Sep 23, 2023
4 checks passed
@sazzad16 sazzad16 deleted the encoded-object-map branch September 23, 2023 13:15
sazzad16 added a commit that referenced this pull request Sep 23, 2023
chenshi5012 pushed a commit to chenshi5012/jedis that referenced this pull request Oct 19, 2023
* 'master' of https://github.com/chenshi5012/jedis: (21 commits)
  Bump org.json:json from 20230618 to 20231013 (redis#3586)
  Fix SORTABLE argument issue in FT.CREATE command (redis#3584)
  Linking to Redis resources (redis#3583)
  Remove patch version snapshots
  Make integration and snapshot actions manually triggerable (redis#3579)
  Missing piece from redis#3578
  Release minor version snapshots (redis#3578)
  Allow getting schema field name (redis#3576)
  Fix binary variants of XRANGE and XREAD commands (redis#3571)
  Support GEOSHAPE field type in RediSearch (redis#3561)
  Bump org.apache.commons:commons-pool2 from 2.11.1 to 2.12.0 (redis#3565)
  Bump junixsocket-core to 2.8.1 (redis#3573)
  Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.5.0 to 3.6.0 (redis#3539)
  Broadcast FUNCTION LOAD command methods (redis#3557)
  Encode map in encoded object (redis#3555)
  Polish Triggers and functions tests (redis#3554)
  Different variable names for json v1 and v2 interfaces (redis#3553)
  Fix Search/Gears test regression (redis#3552)
  Polish Feature: Triggers and functions commands (redis#3551)
  Feature: Triggers and functions commands (redis#3531)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants