Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support white-list and black-list commands and keys #3755

Merged
merged 15 commits into from
Mar 6, 2024

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Mar 5, 2024

  • Separate csc package
  • Add interface for checking client-side cache-ability
  • Support white-list and black-list commands and keys

Closes #3740

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 78.43137% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 75.50%. Comparing base (26606b9) to head (a5abaca).

❗ Current head a5abaca differs from pull request most recent head 5df3093. Consider uploading reports for the commit 5df3093 to get more accurate results

Files Patch % Lines
...c/StringWhiteListBlackListClientSideCacheable.java 61.53% 0 Missing and 5 partials ⚠️
...rc/main/java/redis/clients/jedis/csc/GuavaCSC.java 63.63% 4 Missing ⚠️
...main/java/redis/clients/jedis/csc/CaffeineCSC.java 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.2.0    #3755      +/-   ##
============================================
- Coverage     75.54%   75.50%   -0.04%     
- Complexity     4984     4999      +15     
============================================
  Files           300      302       +2     
  Lines         15241    15279      +38     
  Branches       1157     1162       +5     
============================================
+ Hits          11514    11537      +23     
- Misses         3221     3229       +8     
- Partials        506      513       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 requested review from chayim and gerzse March 5, 2024 18:33
gerzse
gerzse previously approved these changes Mar 6, 2024
Copy link
Contributor

@gerzse gerzse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach feels better encapsulated/isolated.

@sazzad16 sazzad16 requested a review from gerzse March 6, 2024 07:51
@sazzad16 sazzad16 changed the title Support white-list and black-list commands and keys (approach 2) Support white-list and black-list commands and keys Mar 6, 2024
@sazzad16 sazzad16 merged commit 333dcd7 into redis:5.2.0 Mar 6, 2024
3 checks passed
@sazzad16 sazzad16 deleted the csc-white-black-interface branch March 6, 2024 08:03
@sazzad16
Copy link
Collaborator Author

sazzad16 commented Mar 6, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants