Pipelined tests for lists and sets, and API typo fix #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also detected a typo in one of the method names, mark that method as deprecated and add a new one that respects the naming convention.
Sometimes the slow log operation in the binary test actually takes 0 time, so adapt the assert to cover that case too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3772 +/- ##
============================================
+ Coverage 76.67% 77.08% +0.40%
- Complexity 5127 5189 +62
============================================
Files 301 301
Lines 15085 15086 +1
Branches 1134 1134
============================================
+ Hits 11567 11629 +62
+ Misses 3016 2954 -62
- Partials 502 503 +1 ☔ View full report in Codecov by Sentry. |
sazzad16
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pipelined tests for lists and sets. Along the way a typo in an interface
name surfaced, so deprecate that method and add the better named one.