Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expiryOption in PipelineBase.expireAt #3777

Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Mar 18, 2024

One of the expireAt methods in PipelineBase is not using its ExpiryOption argument. Fix this by forwarding that argument too to the commandObjects.

One of the expireAt methods in PipelineBase is not using its
ExpiryOption argument. Fix this by forwarding that argument too to
the commandObjects.
@gerzse gerzse requested a review from sazzad16 March 18, 2024 09:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.69%. Comparing base (a9d3d3e) to head (4224b71).

❗ Current head 4224b71 differs from pull request most recent head a952e3b. Consider uploading reports for the commit a952e3b to get more accurate results

Files Patch % Lines
.../main/java/redis/clients/jedis/PipeliningBase.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3777   +/-   ##
=========================================
  Coverage     76.69%   76.69%           
  Complexity     5129     5129           
=========================================
  Files           301      301           
  Lines         15086    15086           
  Branches       1134     1134           
=========================================
  Hits          11570    11570           
  Misses         3015     3015           
  Partials        501      501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 added this to the 5.2.0 milestone Mar 18, 2024
@sazzad16 sazzad16 merged commit 56ef26a into redis:master Mar 18, 2024
5 checks passed
sazzad16 added a commit that referenced this pull request Mar 23, 2024
@sazzad16 sazzad16 modified the milestones: 5.2.0, 4.4.x, 4.4.8 Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants