Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnifiedJedis pexpireAt glitch #3782

Merged
merged 1 commit into from Mar 22, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Mar 22, 2024

One of the versions of UnifiedJedis.pexpireAt methods is calling the wrong method on CommandObjects.

One of the versions of UnifiedJedis.pexpireAt methods is calling the
wrong method on CommandObjects.
@gerzse gerzse requested a review from sazzad16 March 22, 2024 09:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.65%. Comparing base (8b4f421) to head (712ae76).

❗ Current head 712ae76 differs from pull request most recent head 8566f26. Consider uploading reports for the commit 8566f26 to get more accurate results

Files Patch % Lines
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3782      +/-   ##
============================================
+ Coverage     79.63%   79.65%   +0.02%     
+ Complexity     5572     5571       -1     
============================================
  Files           301      301              
  Lines         15086    15086              
  Branches       1134     1134              
============================================
+ Hits          12013    12017       +4     
+ Misses         2572     2568       -4     
  Partials        501      501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 47df10e into redis:master Mar 22, 2024
5 checks passed
@sazzad16 sazzad16 modified the milestones: 5.2.0, 4.4.x Mar 23, 2024
sazzad16 pushed a commit that referenced this pull request Mar 23, 2024
One of the versions of UnifiedJedis.pexpireAt methods is calling the
wrong method on CommandObjects.

Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
@sazzad16 sazzad16 modified the milestones: 4.4.x, 4.4.8 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants