Renew slot cache if ClusterPipeline.sync results in MOVED response #3816
+52
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this change is to fix a couple issues
MultiNodePipelineBase
:Connection.getMany
are swallowed.JedisMovedDataException
does not trigger a call toJedisClusterInfoCache.renewClusterSlots
(and there may be no other opportunity to callJedisClusterInfoCache.renewClusterSlots
if the application did not specify atopologyRefreshPeriod
when constructingJedisCluster
).With this implementation only the first exception thrown from
Connection.getMany
is rethrown; however this matches the behavior ofPipeline
.