Prevent recursion from Response.build() with dependency (Fixes #856) #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeartSaVioR
commented
Jan 16, 2015
HeartSaVioR
commented
- Before patch it, users could experience StackOverflowError
- when there's multi in Pipeline, which has massive requests
- Change Response.build()'s behavior: now it can be successful when data is JedisDataException
- Instead, Response.get() is responsible for throwing JedisDataException
* Fixes redis#856 * Before patch it, users could experience StackOverflowError ** when there's multi in Pipeline, which has massive requests
|
LGTM. |
|
Checked out your pull request, the test works for me, too, thanks a lot! |
|
👍 lets merge this! |
marcosnils
added a commit
that referenced
this pull request
Feb 4, 2015
…-on-pipeline-with-multi Prevent recursion from Response.build() with dependency (Fixes #856)
marcosnils
added a commit
that referenced
this pull request
Feb 4, 2015
…-on-pipeline-with-multi Prevent recursion from Response.build() with dependency (Fixes #856) Conflicts: src/test/java/redis/clients/jedis/tests/PipeliningTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.