Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce API to allow for extending RedisClusterClient and its connections #1754

Closed
jruaux opened this issue May 18, 2021 · 2 comments
Closed

Introduce API to allow for extending RedisClusterClient and its connections #1754

jruaux opened this issue May 18, 2021 · 2 comments
Labels
type: enhancement A general enhancement
Milestone
6.1.3

Comments

@jruaux
Copy link
Contributor

jruaux commented May 18, 2021

Feature Request

I'm working on an extension of Lettuce to support modules, and similar to issue #33 I would like to introduce 2 methods in RedisClusterClient:

  • newStatefulRedisConnection
  • newStatefulRedisClusterConnection

Also in StatefulRedisClusterConnectionImpl constructor:

this.async = newRedisAdvancedClusterAsyncCommandsImpl();
this.sync = newRedisAdvancedClusterCommandsImpl();
this.reactive = newRedisAdvancedClusterReactiveCommandsImpl();

Happy to submit a PR for this.
@jruaux jruaux changed the title Introduce API to allow for extensions of RedisClusterClient and its connections Introduce API to allow for extending RedisClusterClient and its connections May 18, 2021
@mp911de mp911de added the type: enhancement A general enhancement label May 19, 2021
@mp911de
Copy link
Collaborator

mp911de commented May 19, 2021

Sure, feel free.

@jruaux jruaux mentioned this issue May 19, 2021
Merged
@jruaux
Copy link
Contributor Author

jruaux commented May 19, 2021

Submitted PR #1755

mp911de pushed a commit that referenced this issue Jun 21, 2021
@jruaux
Introduced API to allow for extending RedisClusterClient and its conn…
58a81b6 
…ections #1754

Original pull request: #1755.
@mp911de mp911de added this to the 6.1.3 milestone Jun 21, 2021
mp911de pushed a commit that referenced this issue Jun 21, 2021
@jruaux @mp911de
Introduced API to allow for extending RedisClusterClient and its conn…
d96b90f 
…ections #1754

Original pull request: #1755.
mp911de added a commit that referenced this issue Jun 21, 2021
@mp911de
Polishing #1754
4a07abd 
Reformat code. Fix cluster port.

Original pull request: #1755.
mp911de added a commit that referenced this issue Jun 21, 2021
@mp911de
Polishing #1754
39a9216 
Reformat code. Fix cluster port.

Original pull request: #1755.
@mp911de mp911de closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.3
Development

No branches or pull requests
2 participants
@mp911de @jruaux