ClientResources.mutate() leads to DefaultClientResources was not shut down properly if the original instance is GC'd
#1917
Comments
mp911de
added a commit
that referenced
this issue
Nov 22, 2021
…after mutation #1917 ClientResources now no longer checks if the instance was shut down on finalization to avoid false impression of a resource leak. Typically, the original instance isn't referenced after mutation which allows GC'ing the original resources instance. Because the mutated resource can hold the internal state for thread pool and timer reuse, it is sufficient to close only one instance as long as it shuts down all resources properly.
mp911de
added a commit
that referenced
this issue
Nov 22, 2021
mp911de
added a commit
that referenced
this issue
Nov 22, 2021
mp911de
added a commit
that referenced
this issue
Nov 22, 2021
…after mutation #1917 ClientResources now no longer checks if the instance was shut down on finalization to avoid false impression of a resource leak. Typically, the original instance isn't referenced after mutation which allows GC'ing the original resources instance. Because the mutated resource can hold the internal state for thread pool and timer reuse, it is sufficient to close only one instance as long as it shuts down all resources properly.
mp911de
added a commit
that referenced
this issue
Nov 22, 2021
mp911de
added a commit
that referenced
this issue
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ClientResources.mutate().build()creates a new instance of client resources and shares its internal state (event loops, shared timer, …). When the original instance gets GC'd, then the shutdown check causes a log event that leaves users under the impression that there was a resource leak.See also spring-cloud/spring-cloud-sleuth#2059
The text was updated successfully, but these errors were encountered: