-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io_uring channel used for Unix Domain Sockets #2790
Comments
atakavci
added a commit
to atakavci/lettuce-core
that referenced
this issue
Mar 18, 2024
4 tasks
mp911de
added a commit
that referenced
this issue
Mar 18, 2024
mp911de
added a commit
that referenced
this issue
Mar 18, 2024
That's fixed now. Care to test whether the changes have addressed the issue? |
still got some issues with IOUringEventLoop, |
mp911de
added a commit
that referenced
this issue
Mar 19, 2024
We now distinguish between domain sockets and TCP sockets when obtaining the EventLoopGroup type to avoid compatibility issues across transport implementations.
mp911de
added a commit
that referenced
this issue
Mar 19, 2024
We now distinguish between domain sockets and TCP sockets when obtaining the EventLoopGroup type to avoid compatibility issues across transport implementations.
Good catch, I missed that the EventLoopGroup must fit the transport. I updated the code in a final attempt to retain transport precedence. Can you retest? |
result looks good ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
building on ubuntu 22.04 and having errors from UnixDomainSocketIntegrationTests.
Connection attempts to the server fails as below.
stack trace
io_uring is available in the environment as well as epoll and it is preferred over epoll in current 'NativeTransports' impl in lettuce.
Looks like it doesnt support Unix Domain Socket connections as expected.
Possible Solution
Upon @mp911de 's suggestion , just to experiment, i tried to move the presedence to epoll when both is available and it worked well.
The text was updated successfully, but these errors were encountered: