Skip to content

Fix ACL SETUSER when setting noCommands#1846

Closed
RohanNagar wants to merge 2 commits intoredis:mainfrom
RohanNagar:aclsetuser-nocommands-fix
Closed

Fix ACL SETUSER when setting noCommands#1846
RohanNagar wants to merge 2 commits intoredis:mainfrom
RohanNagar:aclsetuser-nocommands-fix

Conversation

@RohanNagar
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Hi again @mp911de - I found another bug in ACL SETUSER when using the noCommands() method - NOCOMMANDS was not being added to the command arguments.

@mp911de mp911de added the type: bug A general bug label Sep 8, 2021
@mp911de mp911de added this to the 6.1.5 milestone Sep 8, 2021
mp911de pushed a commit that referenced this pull request Sep 8, 2021
mp911de added a commit that referenced this pull request Sep 8, 2021
mp911de pushed a commit that referenced this pull request Sep 8, 2021
mp911de added a commit that referenced this pull request Sep 8, 2021
@mp911de
Copy link
Collaborator

mp911de commented Sep 8, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 8, 2021
@RohanNagar RohanNagar deleted the aclsetuser-nocommands-fix branch September 8, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants