Reduces overhead of RedisClusterNode.forEachSlot #2058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating this issue (#2045), I discovered a minor performance issue.
Current
RedisClusterNode.forEachSlot
callsBitSet.length
every time it loops.The overhead here seems to be big. Please see the framegraph as follows.
We can reduce the overhead by calling
BitSet.length
only once.When measured with JMH, you can see that the throughput(of
RedisClusterNode.forEachSlot
) is improved.Make sure that: