Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #21 - memory leak #22

Merged
merged 2 commits into from
Jan 11, 2015
Merged

Fix issue #21 - memory leak #22

merged 2 commits into from
Jan 11, 2015

Conversation

kichik
Copy link
Contributor

@kichik kichik commented Jan 10, 2015

Read buffer bytes need to be discarded by decode().
See issue #21 for more information.

@kichik
fix issue redis#21 - memory leak
ddc271c 
read buffer bytes need to be discarded by decode()
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling ddc271c on kichik:master into 1d0a3af on mp911de:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling dc91cf9 on kichik:master into 1d0a3af on mp911de:master.

@mp911de
Copy link
Collaborator

mp911de commented Jan 11, 2015

Thanks for the PR. I'll add another buffer.discardReadBytes() in the while loop above.

mp911de added a commit that referenced this pull request Jan 11, 2015
@mp911de
Merge pull request #22 from kichik/master
82a62da 
Fix issue #21 - memory leak
@mp911de mp911de merged commit 82a62da into redis:master Jan 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kichik @coveralls @mp911de