Issue 42 Fix #43
Merged
Issue 42 Fix #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On inturruption, the Command class is nulling the output. But this is causing the statemachine to not know what to do with the actual output it eventually gets. If we leave the output there, the RSM can still update the output, even though the client has moved on.
Make test use same server as rest of tests. Format like rest of code Moved test to proper package Add Cluster test back in
|
Merged. Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issues #42
This relates to a slow processing by a client(codec or *StreamingChannel) or an aggressive timeout. I used the codec to slow it down.