-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for
FT.SEARCH NOCONTENT
(#2610)
* Add support for NOCONTENT in FT.SEARCH * Move support for NOCONTENT search option from client.search to client.searchNoContent * Add test for SEARCH_NOCONTENT#transformReply * Fix typo * Enable test * Update test field type --------- Co-authored-by: Leibale <me@leibale.com>
- Loading branch information
1 parent
1f97893
commit a217cc1
Showing
4 changed files
with
78 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { strict as assert } from 'assert'; | ||
import { SchemaFieldTypes } from '.'; | ||
import testUtils, { GLOBAL } from '../test-utils'; | ||
import { transformArguments, transformReply } from './SEARCH_NOCONTENT'; | ||
|
||
describe('SEARCH_NOCONTENT', () => { | ||
describe('transformArguments', () => { | ||
it('without options', () => { | ||
assert.deepEqual( | ||
transformArguments('index', 'query'), | ||
['FT.SEARCH', 'index', 'query', 'NOCONTENT'] | ||
); | ||
}); | ||
}); | ||
|
||
describe('transformReply', () => { | ||
it('returns total and keys', () => { | ||
assert.deepEqual(transformReply([3, '1', '2', '3']), { | ||
total: 3, | ||
documents: ['1', '2', '3'] | ||
}) | ||
}); | ||
}); | ||
|
||
describe('client.ft.searchNoContent', () => { | ||
testUtils.testWithClient('returns total and keys', async client => { | ||
await Promise.all([ | ||
client.ft.create('index', { | ||
field: SchemaFieldTypes.TEXT | ||
}), | ||
client.hSet('1', 'field', 'field1'), | ||
client.hSet('2', 'field', 'field2'), | ||
client.hSet('3', 'field', 'field3') | ||
]); | ||
|
||
assert.deepEqual( | ||
await client.ft.searchNoContent('index', '*'), | ||
{ | ||
total: 3, | ||
documents: ['1','2','3'] | ||
} | ||
); | ||
}, GLOBAL.SERVERS.OPEN); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { RedisCommandArguments } from "@redis/client/dist/lib/commands"; | ||
import { pushSearchOptions } from "."; | ||
import { SearchOptions, SearchRawReply } from "./SEARCH"; | ||
|
||
export const FIRST_KEY_INDEX = 1; | ||
|
||
export const IS_READ_ONLY = true; | ||
|
||
export function transformArguments( | ||
index: string, | ||
query: string, | ||
options?: SearchOptions | ||
): RedisCommandArguments { | ||
return pushSearchOptions( | ||
['FT.SEARCH', index, query, 'NOCONTENT'], | ||
options | ||
); | ||
} | ||
|
||
export interface SearchNoContentReply { | ||
total: number; | ||
documents: Array<string>; | ||
}; | ||
|
||
export function transformReply(reply: SearchRawReply): SearchNoContentReply { | ||
return { | ||
total: reply[0], | ||
documents: reply.slice(1) | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters