Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Json GET command ignores args #2251

Closed
talsabagport opened this issue Sep 4, 2022 · 1 comment
Closed

Redis Json GET command ignores args #2251

talsabagport opened this issue Sep 4, 2022 · 1 comment
Labels

Comments

@talsabagport
Copy link

Hi,
The new version redis@4.3.0 includes upgrade to @redis/client. One of the changes is the following PR, which includes change to Redis Json GET command (ac032d8#diff-aed1769467eb9d697c271e34e506bb55893f8491c91eefb4f5f1694db37b87c2R20):
image

However it is not part of the last version of @redis/json - 1.0.3 (released before the PR was merged), which is a dependency of redis@4.3.0 (and therefore the change is missing from its dist/).
The impact is that Redis Json GET command ignores the args it gets (because pushVerdictArguments function behavior was changed).
The solution probably is to release new version to @redis/json, and use it as a dependency for redis@4.3.0.

@leibale
Copy link
Collaborator

leibale commented Sep 6, 2022

@talsabagport sorry about that, fixed in redis@4.3.1/@redis/json@1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants