Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts.mRangeWithLabels FILTER as an array of string not apply #2266

Closed
PierreMasson opened this issue Sep 16, 2022 · 7 comments
Closed

ts.mRangeWithLabels FILTER as an array of string not apply #2266

PierreMasson opened this issue Sep 16, 2022 · 7 comments
Labels

Comments

@PierreMasson
Copy link

ts.mRangeWithLabels no longer takes the FILTER parameter into account as an array.

ERR TSDB: missing labels for filter argument

Downgrading to redis 4.1.0 in my package.json do the job.

Maybe this commit #5dd7d3149a633b762ece0ce8006ecbb4311a547f is to blame?

Environment:

  • Node.js Version: 14.18.1
  • Redis Server Version: 6.2.7
  • Node Redis Version: 4.3.1
  • Platform: Debian GNU/Linux 11 (bullseye)
@leibale
Copy link
Collaborator

leibale commented Sep 19, 2022

It's the same bug as #2251 (you can read more about what happened there). I'll release a new version soon with a fix for that as well.

@leibale leibale closed this as completed Oct 27, 2022
@Shepless
Copy link

Shepless commented Nov 3, 2022

@leibale any ETA on the fix being released please?

@leibale
Copy link
Collaborator

leibale commented Nov 6, 2022

@Shepless it's not in redis@4.4.0?

@Shepless
Copy link

Shepless commented Nov 6, 2022

@Shepless it's not in redis@4.4.0?

@leibale I still get a similar error on redis@4.4.0 when using the time series package @redis/time-series@1.0.3

ERR TSDB: missing labels for filter argument

Code snippet:

const labels = [`exchange=${exchange}`, `base=${symbol.base}`, `quote=${symbol.quote}`, `interval=${interval}`]
const data = await this.client.ts.mRangeWithLabels(from, to, labels);

If I downgrade to redis@4.1.0 it works fine. Sorry if this is a separate issue, I just thought they would have been caused by the same problem?

EDIT
If I use redis@4.4.0 and I only pass a single label as a string it doesn't error (but I need to filter with multiple labels)

@Shepless
Copy link

Shepless commented Nov 9, 2022

@leibale sorry to keep bothering you, is the above related to the same issue? If not, do you want me to open a new issue for it? Thank you, all of your work and effort is appreciated 😃

@leibale
Copy link
Collaborator

leibale commented Nov 10, 2022

@Shepless sorry about that, should be fixed in redis@4.5.0/@redis/time-series@1.0.4 :)

@TombolaShepless
Copy link

Thanks @leibale will give it a try this evening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants