Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodeAddressMap config for cluster #1827

Merged
merged 5 commits into from Feb 14, 2022
Merged

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Jan 12, 2022

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #1827 (5894d12) into master (16afa7d) will decrease coverage by 0.11%.
The diff coverage is 55.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
- Coverage   95.05%   94.94%   -0.12%     
==========================================
  Files         358      358              
  Lines        3337     3342       +5     
  Branches      405      409       +4     
==========================================
+ Hits         3172     3173       +1     
- Misses         83       85       +2     
- Partials       82       84       +2     
Impacted Files Coverage Δ
packages/client/lib/cluster/cluster-slots.ts 59.45% <48.00%> (-1.87%) ⬇️
packages/client/lib/cluster/index.ts 78.12% <60.00%> (ø)
packages/client/lib/commands/CLUSTER_NODES.ts 91.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16afa7d...5894d12. Read the comment docs.

Co-authored-by: Guy Royse <guy@guyroyse.com>
@leibale leibale marked this pull request as ready for review February 14, 2022 20:23
@leibale leibale merged commit 0803f4e into redis:master Feb 14, 2022
@leibale leibale deleted the node-address-map branch March 7, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants