Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix socket error handlers #2092

Merged
merged 4 commits into from
Apr 25, 2022
Merged

fix socket error handlers #2092

merged 4 commits into from
Apr 25, 2022

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Apr 21, 2022

Fix #2080, potentially fix #2058, #2032, #1985

@leibale leibale linked an issue Apr 21, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #2092 (2c23787) into master (8b5a547) will decrease coverage by 0.45%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
- Coverage   95.25%   94.79%   -0.46%     
==========================================
  Files         387      387              
  Lines        3517     3496      -21     
  Branches      423      414       -9     
==========================================
- Hits         3350     3314      -36     
- Misses         83      105      +22     
+ Partials       84       77       -7     
Impacted Files Coverage Δ
packages/client/lib/errors.ts 100.00% <ø> (ø)
packages/client/lib/client/commands-queue.ts 81.87% <84.21%> (+1.48%) ⬆️
packages/client/lib/client/index.ts 87.38% <100.00%> (-0.06%) ⬇️
packages/client/lib/client/socket.ts 79.16% <100.00%> (-1.75%) ⬇️
packages/client/lib/commands/SINTERCARD.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/ZINTERCARD.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/CLUSTER_LINKS.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/client/lib/commands/COMMAND_LIST.ts 60.00% <0.00%> (-40.00%) ⬇️
...ges/client/lib/commands/COMMAND_GETKEYSANDFLAGS.ts 60.00% <0.00%> (-40.00%) ⬇️
packages/client/lib/commands/EXPIRETIME.ts 66.66% <0.00%> (-33.34%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5a547...2c23787. Read the comment docs.

@leibale leibale merged commit e6de453 into redis:master Apr 25, 2022
@leibale leibale deleted the error-handlers branch April 25, 2022 10:48
@leibale leibale linked an issue Apr 25, 2022 that may be closed by this pull request
@anshul-kai
Copy link

Thanks for fixing this, guys! Any plans to release this soon in a new version?

@leibale
Copy link
Collaborator Author

leibale commented Apr 25, 2022

@a-koka 4.1.0 will be released in a few days

@micodix
Copy link

micodix commented Apr 25, 2022

Thanks a lot for the fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants