Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency graph command #2359

Merged
merged 5 commits into from Jan 18, 2023
Merged

Add latency graph command #2359

merged 5 commits into from Jan 18, 2023

Conversation

K4ST0R
Copy link
Contributor

@K4ST0R K4ST0R commented Jan 3, 2023

Description

Issue #1954

I have added the implementation of the following command to the project LATENCY GRAPH.

I needed to change docker's configuration to be able to test the command.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@leibale
Copy link
Collaborator

leibale commented Jan 3, 2023

@K4ST0R Thanks for contributing! Wanna review my changes? 🙏

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 95.85% // Head: 95.85% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fa2a506) compared to base (c5b6f77).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2359   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         449      450    +1     
  Lines        4224     4227    +3     
  Branches      471      471           
=======================================
+ Hits         4049     4052    +3     
  Misses        107      107           
  Partials       68       68           
Impacted Files Coverage Δ
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/LATENCY_GRAPH.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

@K4ST0R K4ST0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for reviewing my code :)

Sorry for the coding style 😅

@leibale
Copy link
Collaborator

leibale commented Jan 4, 2023

No worries, code style is a matter of taste, there is no right and wrong..

@leibale leibale merged commit 63511e5 into redis:master Jan 18, 2023
@K4ST0R K4ST0R deleted the LATENCY_GRAPH branch January 18, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants