Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2443 - fix multiple sockets on error in socket initiator #2480

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Apr 24, 2023

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (c88dea6) 95.60% compared to head (ee70b83) 95.66%.

❗ Current head ee70b83 differs from pull request most recent head f2e7859. Consider uploading reports for the commit f2e7859 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2480      +/-   ##
==========================================
+ Coverage   95.60%   95.66%   +0.06%     
==========================================
  Files         455      455              
  Lines        4548     4548              
  Branches      520      520              
==========================================
+ Hits         4348     4351       +3     
+ Misses        129      128       -1     
+ Partials       71       69       -2     
Impacted Files Coverage Δ
packages/client/lib/client/socket.ts 82.94% <100.00%> (+0.77%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SocketClosedUnexpectedlyError while awaiting #initiator results in multiple connecting sockets / connections
2 participants