Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TIMEOUT in FT.AGGREGATE and FT.SEARCH #2488

Merged
merged 8 commits into from May 21, 2023

Conversation

Nanak360
Copy link
Contributor

@Nanak360 Nanak360 commented Apr 28, 2023

fix #2486 - add support for TIMEOUT in FT.AGGREGATE and FT.SEARCH

@Nanak360 Nanak360 marked this pull request as ready for review April 28, 2023 18:18
@Nanak360 Nanak360 marked this pull request as draft April 28, 2023 18:19
Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, check the one comment...

@leibale leibale linked an issue Apr 29, 2023 that may be closed by this pull request
@Nanak360 Nanak360 marked this pull request as ready for review April 29, 2023 22:59
Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! :)

@Nanak360
Copy link
Contributor Author

@leibale I just saw that one test case was failing. I missed to add one param in expected results. My bad.
I have made the test case proper and pushed again.
please have a look

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3273c85) 95.67% compared to head (a4164e8) 95.67%.

❗ Current head a4164e8 differs from pull request most recent head 2a2002e. Consider uploading reports for the commit 2a2002e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2488   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         455      455           
  Lines        4552     4554    +2     
  Branches      522      523    +1     
=======================================
+ Hits         4355     4357    +2     
  Misses        128      128           
  Partials       69       69           
Impacted Files Coverage Δ
packages/search/lib/commands/SEARCH.ts 82.60% <ø> (ø)
packages/search/lib/commands/AGGREGATE.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nanak360
Copy link
Contributor Author

Nanak360 commented May 3, 2023

is this PR good to merge?

@leibale
Copy link
Collaborator

leibale commented May 3, 2023

@Nanak360 yes :)

@leibale leibale changed the title Feature/#2486 add timeout Add support for TIMEOUT in FT.AGGREGATE and FT.SEARCH May 21, 2023
@leibale leibale merged commit 8d37c11 into redis:master May 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TIMEOUT in FT.Aggregate and FT.Search
3 participants