Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XINFO CONSUMERS - add support for the inactive field #2490

Merged
merged 2 commits into from May 21, 2023

Conversation

codrin-ch
Copy link
Contributor

@codrin-ch codrin-ch commented Apr 29, 2023

fix #2461

Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Thanks for contributing!

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3273c85) 95.67% compared to head (e4d36e7) 95.67%.

❗ Current head e4d36e7 differs from pull request most recent head ca69055. Consider uploading reports for the commit ca69055 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2490   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         455      455           
  Lines        4552     4552           
  Branches      522      522           
=======================================
  Hits         4355     4355           
  Misses        128      128           
  Partials       69       69           
Impacted Files Coverage Δ
packages/client/lib/commands/XINFO_CONSUMERS.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leibale leibale changed the title Support XINFO CONSUMERS: Added the inactive field XINFO CONSUMERS - add support for the inactive field May 21, 2023
@leibale leibale merged commit d4f1943 into redis:master May 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XINFO CONSUMERS: Added the inactive field.
4 participants