Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count option to FT.CURSOR READ #2492

Merged
merged 2 commits into from
May 21, 2023
Merged

Add count option to FT.CURSOR READ #2492

merged 2 commits into from
May 21, 2023

Conversation

fast-facts
Copy link
Contributor

Description

The PR provides support for the COUNT argument in FT.CURSOR READ


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Thanks for contributing!

@fast-facts
Copy link
Contributor Author

@leibale I had to fix a bug (options is possible undefined). I forced push an update.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.05 ⚠️

Comparison is base (3273c85) 95.67% compared to head (9cc596b) 95.63%.

❗ Current head 9cc596b differs from pull request most recent head 893117e. Consider uploading reports for the commit 893117e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
- Coverage   95.67%   95.63%   -0.05%     
==========================================
  Files         455      455              
  Lines        4552     4555       +3     
  Branches      522      523       +1     
==========================================
+ Hits         4355     4356       +1     
- Misses        128      129       +1     
- Partials       69       70       +1     
Impacted Files Coverage Δ
packages/search/lib/commands/CURSOR_READ.ts 75.00% <50.00%> (-25.00%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leibale leibale changed the title Feature: Add count option to FT.CURSOR READ Add count option to FT.CURSOR READ May 21, 2023
@leibale leibale merged commit 85091cd into redis:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants