Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON.MERGE #2511

Merged
merged 6 commits into from Sep 18, 2023
Merged

Add support for JSON.MERGE #2511

merged 6 commits into from Sep 18, 2023

Conversation

shacharPash
Copy link
Contributor

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Closes #2500

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (67d9c3c) 95.67% compared to head (4eb9384) 95.67%.

❗ Current head 4eb9384 differs from pull request most recent head cee764e. Consider uploading reports for the commit cee764e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         455      456    +1     
  Lines        4552     4556    +4     
  Branches      522      522           
=======================================
+ Hits         4355     4359    +4     
  Misses        128      128           
  Partials       69       69           
Impacted Files Coverage Δ
packages/json/lib/commands/MERGE.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from leibale May 17, 2023 06:15
packages/json/lib/commands/MERGE.spec.ts Outdated Show resolved Hide resolved
packages/json/lib/commands/MERGE.ts Outdated Show resolved Hide resolved
@shacharPash shacharPash requested a review from leibale May 18, 2023 10:38
@kiyaGu
Copy link

kiyaGu commented Jul 19, 2023

Hi @shacharPash @leibale, do you know when this feature is going to be available?

@leibale
Copy link
Collaborator

leibale commented Jul 19, 2023

@kiyaGu we are waiting for RedisJSON 2.6 to be released, see here

@arsengoian
Copy link

@leibale looks like it has been released several weeks ago

@leibale leibale changed the title Support JSON.MERGE Command Add support for JSON.MERGE Sep 18, 2023
@leibale leibale merged commit cf21c1a into master Sep 18, 2023
9 of 11 checks passed
@leibale leibale deleted the node/SupportJSON.MERGE branch September 18, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON.MERGE
5 participants