fixes #2524 delaying graceful exit while pingInterval is set #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything blocking this? I'm also running into issues with graceful exits after enabling |
|
Normally not, a contributor should just be able to merge it without any issues. |
|
@chayim could you review this please? |
leibale
approved these changes
Aug 16, 2023
|
@apazzolini @jorenvandeweyer sorry about that, I'll take care of it soon |
|
@jorenvandeweyer @apazzolini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2524 delaying graceful exit while pingInterval is set.
Checklist
npm testpass with this change (including linting)?