Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2458 - add support for WAITAOF #2536

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

e920528
Copy link
Contributor

@e920528 e920528 commented Jun 12, 2023

Description

Fix #2458


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (a7d5bc7) 95.70% compared to head (68e79fc) 95.68%.

❗ Current head 68e79fc differs from pull request most recent head 3f5f4cb. Consider uploading reports for the commit 3f5f4cb to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
- Coverage   95.70%   95.68%   -0.02%     
==========================================
  Files         456      457       +1     
  Lines        4561     4564       +3     
  Branches      524      524              
==========================================
+ Hits         4365     4367       +2     
- Misses        127      128       +1     
  Partials       69       69              
Impacted Files Coverage Δ
packages/client/lib/commands/WAITAOF.ts 50.00% <50.00%> (ø)
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@e920528 e920528 marked this pull request as ready for review June 13, 2023 01:19
Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some small changes are needed..

Thanks for contributing!

wait: WAIT
wait: WAIT,
WAITAOF,
waitaof: WAITAOF
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to waitAOF or waitAof (I'm actually not sure which one we should go with :P)

[1, 0]
);
}, GLOBAL.SERVERS.OPEN);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an empty line

];
}

export declare function transformReply(): Array<[number, number]>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an empty line

@e920528
Copy link
Contributor Author

e920528 commented Jun 28, 2023

@leibale Thanks for reviewing!

I make some changes according to your feedback. Please take a look whenever you have time.

@leibale leibale changed the title Fix #2458 Add support for WAITAOF command fix #2458 - add support for WAITAOF Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new redis command WAITAOF
3 participants