Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1956 - add support for LATENCY HISTORY #2555

Merged
merged 3 commits into from Sep 19, 2023

Conversation

avinashkrishna613
Copy link
Contributor

@avinashkrishna613 avinashkrishna613 commented Jul 2, 2023

Description

Its regarding issue #1956 request.

Describe your pull request here

  • A new file that builds the LATENCY HISTORY command line arguments.
  • Update to the general client's commands list.
  • A test file for the latency history command

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@leibale leibale changed the title Issue #1956 added support for LATENCY_HISTORY command fix #1956 - add support for LATENCY HISTORY Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage: 97.43% and project coverage change: +0.03% 🎉

Comparison is base (a7d5bc7) 95.70% compared to head (6213899) 95.73%.
Report is 21 commits behind head on master.

❗ Current head 6213899 differs from pull request most recent head 899d653. Consider uploading reports for the commit 899d653 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2555      +/-   ##
==========================================
+ Coverage   95.70%   95.73%   +0.03%     
==========================================
  Files         456      461       +5     
  Lines        4561     4551      -10     
  Branches      524      510      -14     
==========================================
- Hits         4365     4357       -8     
  Misses        127      127              
+ Partials       69       67       -2     
Files Changed Coverage Δ
packages/search/lib/commands/SEARCH.ts 82.60% <ø> (ø)
packages/client/lib/client/index.ts 92.74% <75.00%> (-0.84%) ⬇️
packages/client/lib/client/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/CLIENT_NO-TOUCH.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/CLUSTER_MYSHARDID.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/LATENCY_HISTORY.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/RESTORE.ts 100.00% <100.00%> (ø)
packages/json/lib/commands/MERGE.ts 100.00% <100.00%> (ø)
packages/search/lib/commands/SEARCH_NOCONTENT.ts 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leibale leibale merged commit 4ec97be into redis:master Sep 19, 2023
12 checks passed
@leibale
Copy link
Collaborator

leibale commented Sep 19, 2023

@avinashkrishna613 redis@4.6.9/@redis/client@1.5.10 is on npm 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants