Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cluster.sUnsubscribe - make listener optional #2641

Merged
merged 1 commit into from Nov 20, 2023

Conversation

Clsan
Copy link
Contributor

@Clsan Clsan commented Oct 26, 2023

Description

  • I don't see any good reason for cluster.client.sUnsubscribe function must hasve listener.
  • So, I changed cluster.client.sUnsubscribe definition. (Make listener optional)
  • When sUnsubscribe is called, client.unsubscribe is called. #
  • It finally goes to pubSub.unsubscribe. #
  • If we register listener on sUnsubscribe, pubSubClient's isActive is true due to pre-registered listener. #
  • So, command is not actually issued. #
  • And, also not disconnected. #

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@leibale leibale changed the title Fix cluster.client.sUnsubscribe's def. (Make listener optional) make listener optional in cluster.sUnsubscribe Nov 20, 2023
@leibale leibale changed the title make listener optional in cluster.sUnsubscribe fix cluster.sUnsubscribe - make listener optional Nov 20, 2023
@leibale leibale merged commit 623b56b into redis:master Nov 20, 2023
12 checks passed
@Clsan Clsan deleted the fix-def branch December 4, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants