Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2632 - handle socket close in "socket initiator" phase #2653

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Nov 15, 2023

Description

fix #2632.

Until this fix, when the server closes the socket (for example, when the server is restarting) in the "socket initiator" phase (while running commands like AUTH, which has to run before all commands), the client hangs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a8b81bd) 95.68% compared to head (24b2da9) 95.68%.

❗ Current head 24b2da9 differs from pull request most recent head 6748ba5. Consider uploading reports for the commit 6748ba5 to get more accurate results

Files Patch % Lines
packages/client/lib/client/socket.ts 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2653   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         462      462           
  Lines        4616     4617    +1     
  Branches      536      536           
=======================================
+ Hits         4417     4418    +1     
+ Misses        127      126    -1     
- Partials       72       73    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@gguimond gguimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue, the only drawback being that the error event is fired.twice in this case.

@leibale leibale merged commit 68d835d into master Nov 20, 2023
12 checks passed
@leibale leibale deleted the fix-2632 branch November 20, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection hangs after temporarily lost connection from redis
3 participants