Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Error object for errors in reply to EXEC #751

Closed
wants to merge 1 commit into from
Closed

Return Error object for errors in reply to EXEC #751

wants to merge 1 commit into from

Conversation

dohse
Copy link
Contributor

@dohse dohse commented May 17, 2015

The javascript reply parser does produces strings instead of Error
objects for errors in replies to EXEC. Return Error objects to be
consistent with hiredis.

Return Error object for errors in reply to EXEC
1e151fd 
The javascript reply parser does produces strings instead of `Error`
objects for errors in replies to EXEC. Return `Error` objects to be
consistent with hiredis.
@bcoe bcoe mentioned this pull request Aug 18, 2015
Closed
@BridgeAR
Copy link
Contributor

BridgeAR commented Sep 4, 2015

Needs a rebase. Otherwise SGTM

@BridgeAR BridgeAR self-assigned this Sep 4, 2015
@BridgeAR BridgeAR mentioned this pull request Sep 8, 2015
Merged
BridgeAR pushed a commit that referenced this pull request Sep 11, 2015
Fix js parser error as suggested in #751
b0186d6
@bcoe
Copy link
Contributor

bcoe commented Sep 13, 2015

@BridgeAR should we close this in favor of #826

@BridgeAR
Copy link
Contributor

Closing this in favor of #826
@dohse I cherry-picked your commit so you'll still get the credit for it.

@BridgeAR BridgeAR closed this Sep 13, 2015
@BridgeAR BridgeAR mentioned this pull request Sep 15, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BridgeAR BridgeAR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dohse @BridgeAR @bcoe