Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis error codes to the errors #858

Merged
merged 3 commits into from Sep 19, 2015
Merged

Add redis error codes to the errors #858

merged 3 commits into from Sep 19, 2015

Conversation

BridgeAR
Copy link
Contributor

This adds redis error codes to the returned errors. We might as well add error classes like parser errors, network errors and similar (the later do not have any error codes yet).

Fixes partly #695 and closes #538

@skeggse
Copy link

skeggse commented Sep 18, 2015

Possible test for error codes:

it('converts lua error to an error response', function (done) {
  helper.serverVersionAtLeast.call(this, client, [2, 6, 0]);
  client.evalsha("ffffffffffffffffffffffffffffffffffffffff", 0, function(err) {
    assert(err.code === "NOSCRIPT");
    helper.isError()(err);
    done();
  });
});

BridgeAR added a commit that referenced this pull request Sep 19, 2015
Add redis error codes to the errors returned by the parser. Fixes #538
@BridgeAR BridgeAR merged commit 6a5e011 into redis:master Sep 19, 2015
@BridgeAR
Copy link
Contributor Author

Thx @skeggse

@skeggse
Copy link

skeggse commented Sep 19, 2015

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants