Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API documentation of EXPIRETIME and PEXPIRETIME commands #1582

Merged
merged 9 commits into from
Jun 15, 2021
Merged

API documentation of EXPIRETIME and PEXPIRETIME commands #1582

merged 9 commits into from
Jun 15, 2021

Conversation

ny0312
Copy link
Contributor

@ny0312 ny0312 commented May 31, 2021

Add API documentation for EXPIRETIME and PEXPIRETIME commands introduced in this PR: redis/redis#8474

@ny0312 ny0312 mentioned this pull request May 31, 2021
Merged
@oranagra oranagra added the to-be-merged should probably be merged soon label Jun 1, 2021
zuiderkwast
zuiderkwast reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. A few nits.

commands/expiretime.md Outdated Show resolved Hide resolved
commands/pexpiretime.md Outdated Show resolved Hide resolved
commands/expiretime.md Outdated Show resolved Hide resolved
commands/expiretime.md Outdated Show resolved Hide resolved
commands.json Outdated Show resolved Hide resolved
commands.json Outdated Show resolved Hide resolved
commands/pexpiretime.md Outdated Show resolved Hide resolved
ny0312 and others added 7 commits June 1, 2021 13:05
@ny0312 @zuiderkwast
Update commands/expiretime.md
9e2ccb5 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@ny0312 @zuiderkwast
Update commands/pexpiretime.md
150ea0c 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@ny0312 @zuiderkwast
Update commands/expiretime.md
b649f7d 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@ny0312 @zuiderkwast
Update commands.json
cd63f06 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@ny0312 @zuiderkwast
Update commands/pexpiretime.md
9665ed4 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@ny0312 @zuiderkwast
Update commands.json
3854c60 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@ny0312 @zuiderkwast
Update commands/expiretime.md
ff8f658 
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
madolson
madolson approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yoav-steinberg
yoav-steinberg reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@yoav-steinberg yoav-steinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor English fix.

commands/expiretime.md Outdated Show resolved Hide resolved
@oranagra @yoav-steinberg
Update commands/expiretime.md
e4a79e6 
Co-authored-by: yoav-steinberg <yoav@monfort.co.il>
@oranagra oranagra merged commit 586b105 into redis:master Jun 15, 2021
@ny0312 ny0312 deleted the expiretime-pexpiretime-doc branch July 2, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoav-steinberg yoav-steinberg yoav-steinberg left review comments

@zuiderkwast zuiderkwast zuiderkwast approved these changes

@oranagra oranagra oranagra approved these changes

@madolson madolson madolson approved these changes

Assignees
No one assigned
Labels
to-be-merged should probably be merged soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ny0312 @zuiderkwast @yoav-steinberg @oranagra @madolson