Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes command arguments doc #2048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itamarhaber
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for redis-doc ready!

Name Link
🔨 Latest commit eacc3e6
🔍 Latest deploy log https://app.netlify.com/sites/redis-doc/deploys/62d6a32a8938a10008f25bc1
😎 Deploy Preview https://deploy-preview-2048--redis-doc.netlify.app/docs/reference/command-arguments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -14,8 +14,7 @@ This key stores an array that describes the command's arguments.
Every element in the _arguments_ array is a map with the following fields:

* **name:** the argument's name, always present.
The name of an argument is given for identification purposes alone.
It isn't displayed during the command's syntax rendering.
The name is displayed during the command's syntax rendering as a placeholder for user input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless it's a "container" argument (not sure about the name) - i.e. "oneof" or "block"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For arguments types other than _oneof_ and _block_, this is a string that describes the value in the command's syntax.

(from below)

@@ -14,8 +14,7 @@ This key stores an array that describes the command's arguments.
Every element in the _arguments_ array is a map with the following fields:

* **name:** the argument's name, always present.
The name of an argument is given for identification purposes alone.
It isn't displayed during the command's syntax rendering.
The name is displayed during the command's syntax rendering as a placeholder for user input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The name is displayed during the command's syntax rendering as a placeholder for user input.
The name is displayed during the command's syntax rendering as a placeholder for user input.
For arguments types other than _oneof_ and _block_, this is a string that describes the value in the command's syntax.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants