Revamps clients/tools/modules #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes recommended from star to heart * Sorting is based on activity and number of stars * Adds twitter avatar to tool authors
madolson
reviewed
Jun 21, 2021
Comment on lines
+69
to
+70
| - if client["github"] && client["github"]["stars"] | ||
| #{client["github"]["stars"]} |
There was a problem hiding this comment.
Suggested change
| - if client["github"] && client["github"]["stars"] | |
| #{client["github"]["stars"]} | |
| #{client.fetch("github", {}).fetch("stars", 0)} |
Will always put something here, and simplifies error handling.
| Modules with some activity in their GitHub repository within the last six months are marked with a <i class="fa fa-smile-o icon"></i>. | ||
|
|
||
| %p | ||
| This list contains two types of modules: modules under an OSI approved license, and modules that are under some proprietary license. Non-OSI modules are clearly flagged as not open source. Also to have the source code hosted at Github is currently mandatory. |
There was a problem hiding this comment.
The RSL and pHash modules aren't really "clearly marked", they have the license listed but I would argue that is not un-ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renders:
