Bugfix: support method call in Any() on embedded objects array #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @slorello89, do you have any updates or feedback regarding the PR?) |
slorello89
approved these changes
May 2, 2024
|
Thanks for adding this @PrudiusVladislav! |
slorello89
added a commit
that referenced
this pull request
Jun 6, 2024
* Bugfix: support method call in Any() on embedded list * adding StartsWith and EndsWith case --------- Co-authored-by: Steve Lorello <42971704+slorello89@users.noreply.github.com> Co-authored-by: slorello89 <steve.lorello@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #441, where
Any()for embedded objects does not support method call expressions (e.g.Contains(),StartsWith()etc.). So, in addition toBinaryExpressiontranslation support, added the handling ofMethodCallExpressioncase. So, it would allow such constructions as, for example:collection.Where(x => x.EmbeddedCollection.Any(a => a.Property.Contains("Value"))). Previously, only basic BinaryExpressions like the equality check '==' were allowed.